Skip to content

Fix _baseImageUriSuffix#88

Merged
Lyokone merged 1 commit intofirebase:mainfrom
kevmoo:fix_base_image
Mar 27, 2026
Merged

Fix _baseImageUriSuffix#88
Lyokone merged 1 commit intofirebase:mainfrom
kevmoo:fix_base_image

Conversation

@kevmoo
Copy link
Copy Markdown
Collaborator

@kevmoo kevmoo commented Mar 26, 2026

before this fix, I hit this error

[debug] [2026-03-26T20:38:48.115Z] Failed to check artifact cleanup policy for region us-central1:Request to https://artifactregistry.googleapis.com/v1/projects/j832-com/locations/us-central1/repositories/gcf-artifacts had HTTP Error: 404, Requested entity was not found. {"name":"FirebaseError","children":[],"context":{"body":{"error":{"code":404,"message":"Requested entity was not found.","status":"NOT_FOUND"}},"response":{"statusCode":404}},"exit":1,"message":"Request to https://artifactregistry.googleapis.com/v1/projects/j832-com/locations/us-central1/repositories/gcf-artifacts had HTTP Error: 404, Requested entity was not found.","status":404}

before this fix, I hit this error

[debug] [2026-03-26T20:38:48.115Z] Failed to check artifact cleanup policy for region us-central1:Request to https://artifactregistry.googleapis.com/v1/projects/j832-com/locations/us-central1/repositories/gcf-artifacts had HTTP Error: 404, Requested entity was not found. {"name":"FirebaseError","children":[],"context":{"body":{"error":{"code":404,"message":"Requested entity was not found.","status":"NOT_FOUND"}},"response":{"statusCode":404}},"exit":1,"message":"Request to https://artifactregistry.googleapis.com/v1/projects/j832-com/locations/us-central1/repositories/gcf-artifacts had HTTP Error: 404, Requested entity was not found.","status":404}
@kevmoo kevmoo requested a review from Lyokone March 26, 2026 22:44
@kevmoo
Copy link
Copy Markdown
Collaborator Author

kevmoo commented Mar 26, 2026

Fixes a likely copy-paste error in e5c7f02

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the base image URI template for Cloud Run deployment in lib/src/builder/manifest.dart by correcting the path to include /runtimes/ and adding a reference link to the official Google Cloud runtime support documentation. I have no feedback to provide.

@kevmoo kevmoo added the bug Something isn't working label Mar 26, 2026
@Lyokone Lyokone merged commit 150721b into firebase:main Mar 27, 2026
8 checks passed
@kevmoo kevmoo deleted the fix_base_image branch March 31, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants